Maintenance: validate domain strings for all providers #363

New Issue

saavagebueno · 2025-11-20T04:23:09-05:00

saavagebueno commented

2025-11-20 04:23:09 -05:00

Originally created by @qdm12 on GitHub (Feb 3, 2024).

All domain strings are not validated for now. It would be good to check at a global scope the domain is

empty
a valid fqdn (without trail dot)

Some providers only use a host and the domain json value can be the empty string (constant value in the code), for example duckdns the domain is always duckdns.org. goip.de can have the domain empty, which defaults to goip.de, but it can also be set for example to goip.it.

Originally created by @qdm12 on GitHub (Feb 3, 2024). All domain strings are not validated for now. It would be good to check at a global scope the domain is - empty - a valid fqdn (without trail dot) Some providers only use a host and the domain json value can be the empty string (constant value in the code), for example duckdns the domain is always duckdns.org. goip.de can have the domain empty, which defaults to goip.de, but it can also be set for example to goip.it.

saavagebueno added the Status: 🔒 After next release Category: Maintenance ⛓️Category: Provider update ♻️ labels 2025-11-20 04:23:09 -05:00

saavagebueno closed this issue

2025-11-20 04:23:09 -05:00

saavagebueno commented

2025-11-20 04:23:10 -05:00

@CyberAustin commented on GitHub (Feb 7, 2024):

I'm taking a stab at this right now. Mostly got it working, just need to get the code to my dev machine at home so I can run all the linting and formatting.

@CyberAustin commented on GitHub (Feb 7, 2024): I'm taking a stab at this right now. Mostly got it working, just need to get the code to my dev machine at home so I can run all the linting and formatting.

saavagebueno commented

2025-11-20 04:23:10 -05:00

@qdm12 commented on GitHub (Feb 7, 2024):

Awesome (no pressure either)
You can probably develop with the development container (see .devcontainer directory) if you have Docker and VSCode installed, that's what I use (from a directory in WSL2 on windows)

@qdm12 commented on GitHub (Feb 7, 2024): Awesome (no pressure either) You can probably develop with the development container (see .devcontainer directory) if you have Docker and VSCode installed, that's what I use (from a directory in WSL2 on windows)

saavagebueno commented

2025-11-20 04:23:10 -05:00

@CyberAustin commented on GitHub (Feb 7, 2024):

Yeah, I use your include dev container. It's just that I'm at work and only have access to limited resources during work hours.

@CyberAustin commented on GitHub (Feb 7, 2024): Yeah, I use your include dev container. It's just that I'm at work and only have access to limited resources during work hours.

saavagebueno commented

2025-11-20 04:23:11 -05:00

@CyberAustin commented on GitHub (Feb 7, 2024):

PR created: https://github.com/qdm12/ddns-updater/pull/638

@CyberAustin commented on GitHub (Feb 7, 2024): PR created: https://github.com/qdm12/ddns-updater/pull/638

saavagebueno referenced this issue

2025-11-20 04:25:42 -05:00

[PR #363] [MERGED] Update cloudflare.md #681

Sign in to join this conversation.