mirror of
https://github.com/qdm12/ddns-updater.git
synced 2026-08-02 10:38:41 -04:00
Bug: Output thousands of lines when WebUI or healthcheck server port been used by another program. #398
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Cassy-Lee on GitHub (May 14, 2024).
TLDR: Output thousands of lines when WebUI or healthcheck server port been used by another program.
Running version 2.6.0 built on 2024-02-03T18:57:00Z (commit c338c28ce3ab3aa9948f0fe133307b75fe6d34d2)Host OS: linux aarch64
Simple solutions:
Give options to disable unnecessary features(WebUI and health server). Such as "DISABLE_WEBUI" and "DISABLE_HEALTH_SERVER" environment variables.
Add retry limit for server restart to avoid spam.
Suggestions:
Allow some configs in the config file, not only command line and environment variables.
Remove (or disable) features for dockers in the standalone binary.
@qdm12 commented on GitHub (Jun 13, 2024):
Done in
776206eec8- the healthcheck server won't run when outside Docker 😉This is solved from commit
130ab008b5where a critical error terminates the whole program. Only the backup service is auto-restarted (to zip config.json and updates.json).I don't think anyone would want to disable the web ui or the health server when in Docker really, since they can just not publish ports etc. I have however added
SERVER_ENABLEDincc995a79c8to disable the http server (web ui) when running outside Docker since it could get handy.