mirror of
https://github.com/qdm12/ddns-updater.git
synced 2026-07-10 16:01:53 -04:00
invalid domain name format "test.services" with docker #55
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @marcuslannister on GitHub (Sep 4, 2020).
It seams that it can not recognize "test.services" on config file, I change to "test.ser", then is ok.
here is my docker compose file, same as example.
@qdm12 commented on GitHub (Sep 4, 2020):
I'm not sure I understand your problem, can you please elaborate more? Thanks!
@marcuslannister commented on GitHub (Sep 4, 2020):
sorry, I miss config file, below is my config file.
when i start docker ddns-updater, it is fail.
fail log is
when i change "domain": "test.services" to "domain": "test.ser", it is ok.
@qdm12 commented on GitHub (Sep 4, 2020):
That's because it uses this regex to verify the format of the domain. I'll update it to support more top level domain names, maybe remove it as well as it shouldn't be really useful. I'll do that tomorrow morning, thanks for your patience and for reporting the issue!
@marcuslannister commented on GitHub (Sep 4, 2020):
got it and thanks.
@marcuslannister commented on GitHub (Sep 4, 2020):
one more thing, could you please add he.net support? ^_^
@qdm12 commented on GitHub (Sep 5, 2020):
I removed the domain check so it should work with any domain name now. Anyway it's your responsibility to set the right domain name I guess 😄 Thanks again for the time creating the issue.