[PR #48] [MERGED] Golangci lint and fixing lint issues #593

New Issue

saavagebueno · 2025-11-20T04:25:22-05:00

saavagebueno commented

2025-11-20 04:25:22 -05:00

📋 Pull Request Information

Original PR: https://github.com/qdm12/ddns-updater/pull/48
Author: @qdm12
Created: 4/4/2020
Status: ✅ Merged
Merged: 4/4/2020
Merged by: @qdm12

Base: master ← Head: golangci-lint

📝 Commits (4)

5775a20 Golang ci lint setup
95c971e Fix all lint issues
2f09245 Fix golangci-lint install in Dockerfile
bc6ba20 Readme TODOs update

📊 Changes

26 files changed (+1136 additions, -975 deletions)

View changed files

📝 .dockerignore (+2 -1)
➕ .golangci.yml (+50 -0)
📝 Dockerfile (+4 -0)
📝 README.md (+2 -1)
📝 cmd/updater/main.go (+137 -132)
📝 internal/constants/html.go (+23 -23)
📝 internal/constants/regex.go (+5 -5)
📝 internal/env/env.go (+132 -132)
📝 internal/handlers/handlers.go (+4 -4)
📝 internal/html/html.go (+29 -28)
📝 internal/models/alias.go (+14 -14)
📝 internal/models/html.go (+19 -19)
📝 internal/models/settings.go (+57 -55)
📝 internal/network/publicip.go (+8 -8)
📝 internal/network/requests.go (+2 -2)
📝 internal/params/consistency.go (+161 -82)
📝 internal/params/json.go (+91 -90)
📝 internal/params/params.go (+90 -90)
📝 internal/params/version.go (+6 -6)
📝 internal/persistence/json/database.go (+6 -6)

...and 6 more files

📄 Description

Golangci-lint in Docker build
Golangci-lint issues all fixed in code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qdm12/ddns-updater/pull/48 **Author:** [@qdm12](https://github.com/qdm12) **Created:** 4/4/2020 **Status:** ✅ Merged **Merged:** 4/4/2020 **Merged by:** [@qdm12](https://github.com/qdm12) **Base:** `master` ← **Head:** `golangci-lint` --- ### 📝 Commits (4) - [`5775a20`](https://github.com/qdm12/ddns-updater/commit/5775a20727db403f9ee2f370c731b3d151090bbe) Golang ci lint setup - [`95c971e`](https://github.com/qdm12/ddns-updater/commit/95c971e6454d067ce9c952819fc30f044753dc32) Fix all lint issues - [`2f09245`](https://github.com/qdm12/ddns-updater/commit/2f092455bae928a657bd3d286195990ecdf4ba27) Fix golangci-lint install in Dockerfile - [`bc6ba20`](https://github.com/qdm12/ddns-updater/commit/bc6ba20e6bac1f5fdaedc245e6b87e409338647d) Readme TODOs update ### 📊 Changes **26 files changed** (+1136 additions, -975 deletions) <details> <summary>View changed files</summary> 📝 `.dockerignore` (+2 -1) ➕ `.golangci.yml` (+50 -0) 📝 `Dockerfile` (+4 -0) 📝 `README.md` (+2 -1) 📝 `cmd/updater/main.go` (+137 -132) 📝 `internal/constants/html.go` (+23 -23) 📝 `internal/constants/regex.go` (+5 -5) 📝 `internal/env/env.go` (+132 -132) 📝 `internal/handlers/handlers.go` (+4 -4) 📝 `internal/html/html.go` (+29 -28) 📝 `internal/models/alias.go` (+14 -14) 📝 `internal/models/html.go` (+19 -19) 📝 `internal/models/settings.go` (+57 -55) 📝 `internal/network/publicip.go` (+8 -8) 📝 `internal/network/requests.go` (+2 -2) 📝 `internal/params/consistency.go` (+161 -82) 📝 `internal/params/json.go` (+91 -90) 📝 `internal/params/params.go` (+90 -90) 📝 `internal/params/version.go` (+6 -6) 📝 `internal/persistence/json/database.go` (+6 -6) _...and 6 more files_ </details> ### 📄 Description - Golangci-lint in Docker build - Golangci-lint issues all fixed in code --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

saavagebueno added the pull-request label 2025-11-20 04:25:22 -05:00

saavagebueno closed this issue

2025-11-20 04:25:22 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ddns-updater#593