[PR #63] [MERGED] Refactoring #600

New Issue

saavagebueno · 2025-11-20T04:25:23-05:00

saavagebueno commented

2025-11-20 04:25:23 -05:00

📋 Pull Request Information

Original PR: https://github.com/qdm12/ddns-updater/pull/63
Author: @qdm12
Created: 5/28/2020
Status: ✅ Merged
Merged: 5/29/2020
Merged by: @qdm12

Base: master ← Head: refactor

📝 Commits (7)

e44d4aa Minor buildx workflows changes
c12393b Refactoring
577edfd Fix provider constructor for ipversion
d90cab1 Fix update using new ip address instead of old
21bd7d9 Run loop fixes and force update fix
2a4debb update golangci-lint to 1.27.x
f0eea7b Reduce updateNecessary cognitive complexity

📊 Changes

59 files changed (+2524 additions, -1745 deletions)

View changed files

📝 .github/workflows/buildx-latest.yml (+0 -2)
📝 .github/workflows/buildx-release.yml (+1 -3)
📝 .golangci.yml (+1 -1)
📝 Dockerfile (+19 -8)
📝 README.md (+32 -35)
📝 cmd/updater/main.go (+68 -57)
📝 config.json (+0 -5)
📝 docker-compose.yml (+15 -6)
📝 go.mod (+1 -1)
📝 go.sum (+2 -0)
➖ internal/constants/html.go (+0 -36)
📝 internal/constants/ip.go (+3 -2)
📝 internal/constants/ipmethod.go (+43 -45)
➖ internal/constants/ipmethod_test.go (+0 -20)
📝 internal/data/data.go (+7 -6)
📝 internal/data/memory.go (+4 -4)
📝 internal/data/persistence.go (+4 -3)
📝 internal/handlers/handlers.go (+13 -43)
📝 internal/healthcheck/healthcheck.go (+1 -1)
➖ internal/html/html.go (+0 -134)

...and 39 more files

📄 Description

Only request DNS updates once IP address changes (refer to #56 )
Better code overall and more unit testing
Better support to update ipv6 addresses
Supports updating ipv4 and ipv6 addresses at the same time, for supported providers (i.e. infomaniak, ddnss, etc.)
Supports updating ipv4 or ipv6 (whichever comes first)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qdm12/ddns-updater/pull/63 **Author:** [@qdm12](https://github.com/qdm12) **Created:** 5/28/2020 **Status:** ✅ Merged **Merged:** 5/29/2020 **Merged by:** [@qdm12](https://github.com/qdm12) **Base:** `master` ← **Head:** `refactor` --- ### 📝 Commits (7) - [`e44d4aa`](https://github.com/qdm12/ddns-updater/commit/e44d4aa52ff522f22a82c989e9afcd61c80be0f4) Minor buildx workflows changes - [`c12393b`](https://github.com/qdm12/ddns-updater/commit/c12393bea31894171bce7f124b15e22addec1805) Refactoring - [`577edfd`](https://github.com/qdm12/ddns-updater/commit/577edfd99d4e4ea4e4b1e3e3407e19f6b7ac195e) Fix provider constructor for ipversion - [`d90cab1`](https://github.com/qdm12/ddns-updater/commit/d90cab10fd2eb4decd79697a3d3ccba8dab61377) Fix update using new ip address instead of old - [`21bd7d9`](https://github.com/qdm12/ddns-updater/commit/21bd7d9b13340f393bd1d0e1641d4055917f6a90) Run loop fixes and force update fix - [`2a4debb`](https://github.com/qdm12/ddns-updater/commit/2a4debbe7514b04461add26c9c807ae2a975f0e2) update golangci-lint to 1.27.x - [`f0eea7b`](https://github.com/qdm12/ddns-updater/commit/f0eea7bf35b7daddb3697206bf93e9a3b2a2cd53) Reduce updateNecessary cognitive complexity ### 📊 Changes **59 files changed** (+2524 additions, -1745 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/buildx-latest.yml` (+0 -2) 📝 `.github/workflows/buildx-release.yml` (+1 -3) 📝 `.golangci.yml` (+1 -1) 📝 `Dockerfile` (+19 -8) 📝 `README.md` (+32 -35) 📝 `cmd/updater/main.go` (+68 -57) 📝 `config.json` (+0 -5) 📝 `docker-compose.yml` (+15 -6) 📝 `go.mod` (+1 -1) 📝 `go.sum` (+2 -0) ➖ `internal/constants/html.go` (+0 -36) 📝 `internal/constants/ip.go` (+3 -2) 📝 `internal/constants/ipmethod.go` (+43 -45) ➖ `internal/constants/ipmethod_test.go` (+0 -20) 📝 `internal/data/data.go` (+7 -6) 📝 `internal/data/memory.go` (+4 -4) 📝 `internal/data/persistence.go` (+4 -3) 📝 `internal/handlers/handlers.go` (+13 -43) 📝 `internal/healthcheck/healthcheck.go` (+1 -1) ➖ `internal/html/html.go` (+0 -134) _...and 39 more files_ </details> ### 📄 Description - Only request DNS updates once IP address changes (refer to #56 ) - Better code overall and more unit testing - Better support to update ipv6 addresses - Supports updating ipv4 and ipv6 addresses at the same time, for supported providers (i.e. infomaniak, ddnss, etc.) - Supports updating ipv4 or ipv6 (whichever comes first) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

saavagebueno added the pull-request label 2025-11-20 04:25:23 -05:00

saavagebueno closed this issue

2025-11-20 04:25:23 -05:00

saavagebueno referenced this issue

2025-11-20 04:25:57 -05:00

[PR #600] [MERGED] chore(deps): bump github.com/miekg/dns from 1.1.57 to 1.1.58 #752

saavagebueno referenced this issue

2025-11-20 04:25:57 -05:00

[PR #600] chore(deps): bump github.com/miekg/dns from 1.1.57 to 1.1.58 #756

Sign in to join this conversation.