[PR #159] [MERGED] ddnsgopher favicon #629

New Issue

saavagebueno · 2025-11-20T04:25:30-05:00

saavagebueno commented

2025-11-20 04:25:30 -05:00

📋 Pull Request Information

Original PR: https://github.com/qdm12/ddns-updater/pull/159
Author: @fredericrous
Created: 1/28/2021
Status: ✅ Merged
Merged: 2/11/2021
Merged by: @qdm12

Base: master ← Head: favicon

📝 Commits (3)

3432ab1 ddnsgopher favicon
9a8d397 ddnsgopher favicon source
6957fd0 exclude favicon.svg from docker image

📊 Changes

4 files changed (+3 additions, -0 deletions)

View changed files

📝 .dockerignore (+1 -0)
📝 ui/favicon.ico (+0 -0)
➕ ui/favicon.svg (+1 -0)
📝 ui/index.html (+1 -0)

📄 Description

Here is a favicon proposal. svg source + ico export

I also added the favicon link to the index.html most browsers knows where to find the favicon.ico. However, the recommended way by the w3c is to use the link tag.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qdm12/ddns-updater/pull/159 **Author:** [@fredericrous](https://github.com/fredericrous) **Created:** 1/28/2021 **Status:** ✅ Merged **Merged:** 2/11/2021 **Merged by:** [@qdm12](https://github.com/qdm12) **Base:** `master` ← **Head:** `favicon` --- ### 📝 Commits (3) - [`3432ab1`](https://github.com/qdm12/ddns-updater/commit/3432ab1985638f85e44d27f08034dfc0af203f29) ddnsgopher favicon - [`9a8d397`](https://github.com/qdm12/ddns-updater/commit/9a8d3975e387351d2e3f564fa791da913bd9df54) ddnsgopher favicon source - [`6957fd0`](https://github.com/qdm12/ddns-updater/commit/6957fd07a8992041a4a5e3fe8ff916ca93a59d79) exclude favicon.svg from docker image ### 📊 Changes **4 files changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.dockerignore` (+1 -0) 📝 `ui/favicon.ico` (+0 -0) ➕ `ui/favicon.svg` (+1 -0) 📝 `ui/index.html` (+1 -0) </details> ### 📄 Description Here is a favicon proposal. svg source + ico export ![image](https://user-images.githubusercontent.com/702227/106154773-dbb4e500-6177-11eb-97c4-ab1c57f6446b.png) I also added the favicon link to the index.html most browsers knows where to find the favicon.ico. However, the recommended way by the w3c is to use the link tag. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

saavagebueno added the pull-request label 2025-11-20 04:25:30 -05:00

saavagebueno closed this issue

2025-11-20 04:25:30 -05:00

saavagebueno referenced this issue

2025-11-20 04:25:59 -05:00

[PR #629] [MERGED] chore(deps): bump DavidAnson/markdownlint-cli2-action from 14 to 15 #764

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ddns-updater#629