starred/ddns-updater
1
0
Fork 0
mirror of https://github.com/qdm12/ddns-updater.git synced 2026-06-08 00:01:53 -04:00
Code Issues 312 Packages Projects Releases 10 Wiki Activity

[PR #154] [MERGED] [ovh] Add support for * sub domain #631

New Issue
Closed
opened 2025-11-20 04:25:30 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:25:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/qdm12/ddns-updater/pull/154
Author: @fredericrous
Created: 1/27/2021
Status: ✅ Merged
Merged: 1/28/2021
Merged by: @qdm12

Base: master ← Head: ovh/zonedns

📝 Commits (10+)

  • a8f0723 [ovh] Add support for * host
  • c6ecf72 Implement Review: Update docs/ovh.md
  • 1b37c38 Implement Review: Update internal/settings/ovh.go
  • f2fab9d Implement Review: Update internal/settings/ovh.go
  • f8ba0b5 Implement Review
  • 1f1de64 fix lint
  • 62ec6ef Implement Review: update docs/ovh.md
  • 06ce7dd Implement Review: Update internal/settings/ovh.go
  • baba1bc Implement Review: Update internal/settings/ovh.go
  • 8fd6af9 Implement Review: Update internal/settings/ovh.go

📊 Changes

5 files changed (+144 additions, -9 deletions)

View changed files

📝 docs/ovh.md (+16 -0)
📝 go.mod (+1 -0)
📝 go.sum (+9 -0)
📝 internal/settings/errors.go (+3 -0)
📝 internal/settings/ovh.go (+115 -9)

📄 Description

This PR introduces support for subdomain record actualization (A * or else)

This solves issue https://github.com/qdm12/ddns-updater/issues/153

This PR introduces a new go package, ovh-go. I am usually reluctant to add external packages. However, the requests to OVH API have to be signed with a complicated algorithm. Not using their packages would mean maintaining kinda the same amount of code the ovh-go package has + introduce tests for the request signature which are already done in the ovh-go package.

I tested record creation and record update for A @ and A *. The PR also supports AAAA but I don't use it

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/qdm12/ddns-updater/pull/154 **Author:** [@fredericrous](https://github.com/fredericrous) **Created:** 1/27/2021 **Status:** ✅ Merged **Merged:** 1/28/2021 **Merged by:** [@qdm12](https://github.com/qdm12) **Base:** `master` ← **Head:** `ovh/zonedns` --- ### 📝 Commits (10+) - [`a8f0723`](https://github.com/qdm12/ddns-updater/commit/a8f07231b4ee9789722778848462e122b4c0fd2a) [ovh] Add support for * host - [`c6ecf72`](https://github.com/qdm12/ddns-updater/commit/c6ecf721ca14c7eef6f85ad92cfb8cce48070e56) Implement Review: Update docs/ovh.md - [`1b37c38`](https://github.com/qdm12/ddns-updater/commit/1b37c3808837ac70473edf02a421284b396fb3ef) Implement Review: Update internal/settings/ovh.go - [`f2fab9d`](https://github.com/qdm12/ddns-updater/commit/f2fab9dd11dc14b1f5ea3e0900b5effb0e987413) Implement Review: Update internal/settings/ovh.go - [`f8ba0b5`](https://github.com/qdm12/ddns-updater/commit/f8ba0b5f9a44cc0ad4710c49f3e7af1aad045f78) Implement Review - [`1f1de64`](https://github.com/qdm12/ddns-updater/commit/1f1de6462f971a346660ea2a69fa46474bb49026) fix lint - [`62ec6ef`](https://github.com/qdm12/ddns-updater/commit/62ec6ef7e7ad9693f235ed6d5c9c4fa35e1e52d3) Implement Review: update docs/ovh.md - [`06ce7dd`](https://github.com/qdm12/ddns-updater/commit/06ce7ddbdaf879ada499df8c5b1166f0f05e1d28) Implement Review: Update internal/settings/ovh.go - [`baba1bc`](https://github.com/qdm12/ddns-updater/commit/baba1bc6a197efedb25c0d7399afa171a49db588) Implement Review: Update internal/settings/ovh.go - [`8fd6af9`](https://github.com/qdm12/ddns-updater/commit/8fd6af9c5ca1870b5a4776b7a2696b457e63823c) Implement Review: Update internal/settings/ovh.go ### 📊 Changes **5 files changed** (+144 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `docs/ovh.md` (+16 -0) 📝 `go.mod` (+1 -0) 📝 `go.sum` (+9 -0) 📝 `internal/settings/errors.go` (+3 -0) 📝 `internal/settings/ovh.go` (+115 -9) </details> ### 📄 Description This PR introduces support for subdomain record actualization (A * or else) This solves issue https://github.com/qdm12/ddns-updater/issues/153 This PR introduces a new go package, ovh-go. I am usually reluctant to add external packages. However, the requests to OVH API have to be signed with a complicated algorithm. Not using their packages would mean maintaining kinda the same amount of code the ovh-go package has + introduce tests for the request signature which are already done in the ovh-go package. I tested record creation and record update for A @ and A *. The PR also supports AAAA but I don't use it --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:25:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Category: Config problem 📝
Category: Database 🗃️
Category: Documentation ✒️
Category: Foolproof settings 👼
Category: Good idea 🎯
Category: Healthcheck 🩺
Category: IP fetching 📥
Category: Label missing ❗
Category: Maintenance ⛓️
Category: Motivated! 🙌
Category: New provider 🆕
Category: Provider update ♻️
Category: Shoutrrr 📢
Category: Web UI 🖱️
Category: Wildcard 🃏
Closed: ⚰️ Inactive
Closed: 👥 Duplicate
Closed: 🗑️ Bad issue
Complexity: ☣️ Hard to do
Complexity: 🟩 Easy to do
Priority: 💤 Low priority
Priority: 🚨 Urgent
pull-request
Mirrored from GitHub Pull Request
 Status: 🔒 After next release
Status: 🔴 Blocked
Status: 🗯️ Waiting for feedback
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ddns-updater#631
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?