[PR #164] [MERGED] HTTP server refactor #634

New Issue

saavagebueno · 2025-11-20T04:25:32-05:00

saavagebueno commented

2025-11-20 04:25:32 -05:00

📋 Pull Request Information

Original PR: https://github.com/qdm12/ddns-updater/pull/164
Author: @qdm12
Created: 2/2/2021
Status: ✅ Merged
Merged: 2/8/2021
Merged by: @qdm12

Base: master ← Head: http-server

📝 Commits (5)

128bb7a Rework current server
dd8920e Make update call blocking
6fc90cb Fix channel not created
ca084e5 Make ForceUpdate context aware
539f703 Run first update without blocking

📊 Changes

10 files changed (+169 additions, -60 deletions)

View changed files

📝 cmd/updater/main.go (+7 -4)
📝 go.mod (+1 -0)
📝 go.sum (+2 -0)
➕ internal/server/error.go (+35 -0)
➕ internal/server/fileserver.go (+24 -0)
📝 internal/server/handler.go (+35 -48)
➕ internal/server/index.go (+18 -0)
📝 internal/server/server.go (+4 -3)
➕ internal/server/update.go (+18 -0)
📝 internal/update/run.go (+25 -5)

📄 Description

Fixes ERROR cannot unmarshal common settings: unexpected end of JSON input (#148)
Paves way for Bug: non-update shows as update (#75)
Unblocks netcup.de (#159)
Also makes the call to GET /update blocking until all updates are done

I skipped adding unit tests as I would like to get moving with an API server and a client side UI (react) which would change the routes quite a bit (in a subsequent PR). Also sorry for the delay @fredericrous was caught up in other repos essentially 😄

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qdm12/ddns-updater/pull/164 **Author:** [@qdm12](https://github.com/qdm12) **Created:** 2/2/2021 **Status:** ✅ Merged **Merged:** 2/8/2021 **Merged by:** [@qdm12](https://github.com/qdm12) **Base:** `master` ← **Head:** `http-server` --- ### 📝 Commits (5) - [`128bb7a`](https://github.com/qdm12/ddns-updater/commit/128bb7abbf93d038340cae0bc44fe0f3b3a83cae) Rework current server - [`dd8920e`](https://github.com/qdm12/ddns-updater/commit/dd8920ec15ba7d4017436fa5085435a27058e438) Make update call blocking - [`6fc90cb`](https://github.com/qdm12/ddns-updater/commit/6fc90cbab524cf81dd59752d06eff28b91c7fc3e) Fix channel not created - [`ca084e5`](https://github.com/qdm12/ddns-updater/commit/ca084e57254b4d0d7a724bfcdaa6fe24f3809eab) Make ForceUpdate context aware - [`539f703`](https://github.com/qdm12/ddns-updater/commit/539f70315adca4d253511a22ac7e9e7d45932584) Run first update without blocking ### 📊 Changes **10 files changed** (+169 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `cmd/updater/main.go` (+7 -4) 📝 `go.mod` (+1 -0) 📝 `go.sum` (+2 -0) ➕ `internal/server/error.go` (+35 -0) ➕ `internal/server/fileserver.go` (+24 -0) 📝 `internal/server/handler.go` (+35 -48) ➕ `internal/server/index.go` (+18 -0) 📝 `internal/server/server.go` (+4 -3) ➕ `internal/server/update.go` (+18 -0) 📝 `internal/update/run.go` (+25 -5) </details> ### 📄 Description - Fixes #148 - Paves way for #75 - Unblocks #159 - Also makes the call to `GET /update` blocking until all updates are done I skipped adding unit tests as I would like to get moving with an API server and a client side UI (react) which would change the routes quite a bit (in a subsequent PR). Also sorry for the delay @fredericrous was caught up in other repos essentially 😄 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

saavagebueno added the pull-request label 2025-11-20 04:25:32 -05:00

saavagebueno referenced this issue

2025-11-20 04:26:01 -05:00

[PR #634] [MERGED] Support named volumes #771

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ddns-updater#634