[PR #270] [CLOSED] Fix DDNSS provider specific IPv6 update flow #669

Closed
opened 2025-11-20 04:25:39 -05:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/qdm12/ddns-updater/pull/270
Author: @quantum-byte
Created: 11/25/2021
Status: Closed

Base: masterHead: master


📝 Commits (1)

  • 5e3344e added .Idea to .gitignore

📊 Changes

2 files changed (+2 additions, -5 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 internal/settings/providers/ddnss/provider.go (+1 -5)

📄 Description

Fixed sending of specific ipv6 information to DDNSS provider.

The DDNSS provider only has one keyword (ip) for specifying the new ip (see documentation.

Currently when an ipv6 ip would be provided the ip6 keyword is filled. This leads to the behaviour that DDNSS picks the ip to fill since the ip keyword is missing. This is not expected behaviour if useProviderIP=false.

I tested it with my own account/setup. Feel free to validate with something like the following:
curl -i "https://www.ddnss.de/upd.php?key=<APIKEY>&host=<HOSTNAME>&ip=<IPV6>"


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/qdm12/ddns-updater/pull/270 **Author:** [@quantum-byte](https://github.com/quantum-byte) **Created:** 11/25/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`5e3344e`](https://github.com/qdm12/ddns-updater/commit/5e3344e44552726cfa4f5de3ab230d881ecc1bcf) added .Idea to .gitignore ### 📊 Changes **2 files changed** (+2 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `internal/settings/providers/ddnss/provider.go` (+1 -5) </details> ### 📄 Description Fixed sending of specific ipv6 information to DDNSS provider. The DDNSS provider only has one keyword (`ip`) for specifying the new ip (see [documentation](https://ddnss.de/ua/help.php). Currently when an ipv6 ip would be provided the `ip6` keyword is filled. This leads to the behaviour that DDNSS picks the ip to fill since the `ip` keyword is missing. This is not expected behaviour if `useProviderIP=false`. I tested it with my own account/setup. Feel free to validate with something like the following: `curl -i "https://www.ddnss.de/upd.php?key=<APIKEY>&host=<HOSTNAME>&ip=<IPV6>"` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:25:39 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ddns-updater#669