mirror of
https://github.com/qdm12/ddns-updater.git
synced 2026-08-02 18:48:49 -04:00
[PR #270] [CLOSED] Fix DDNSS provider specific IPv6 update flow #669
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/qdm12/ddns-updater/pull/270
Author: @quantum-byte
Created: 11/25/2021
Status: ❌ Closed
Base:
master← Head:master📝 Commits (1)
5e3344eadded .Idea to .gitignore📊 Changes
2 files changed (+2 additions, -5 deletions)
View changed files
📝
.gitignore(+1 -0)📝
internal/settings/providers/ddnss/provider.go(+1 -5)📄 Description
Fixed sending of specific ipv6 information to DDNSS provider.
The DDNSS provider only has one keyword (
ip) for specifying the new ip (see documentation.Currently when an ipv6 ip would be provided the
ip6keyword is filled. This leads to the behaviour that DDNSS picks the ip to fill since theipkeyword is missing. This is not expected behaviour ifuseProviderIP=false.I tested it with my own account/setup. Feel free to validate with something like the following:
curl -i "https://www.ddnss.de/upd.php?key=<APIKEY>&host=<HOSTNAME>&ip=<IPV6>"🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.