[PR #473] [MERGED] possible fix for panic on inwx #710

New Issue

saavagebueno · 2025-11-20T04:25:48-05:00

saavagebueno commented

2025-11-20 04:25:48 -05:00

📋 Pull Request Information

Original PR: https://github.com/qdm12/ddns-updater/pull/473
Author: @stavros-k
Created: 5/4/2023
Status: ✅ Merged
Merged: 5/9/2023
Merged by: @qdm12

Base: master ← Head: patch-10

📝 Commits (1)

ed76876 possible fix for panic

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 internal/settings/providers/inwx/provider.go (+1 -1)

📄 Description

I was getting a panic for inwx provider, from looking in the other providers looks like others was using this format instead of var.

I have no Go Experiene, so this might be plain wrong.

Here is the panic.

panic: assignment to entry in nil map

goroutine 71 [running]:
net/url.Values.Set(...)
        net/url/url.go:899
github.com/qdm12/ddns-updater/internal/settings/providers/inwx.(*Provider).Update(0xc0003181e0, {0xdd4848, 0xc00071e9b0}, 0x0?, {0xc000492120, 0x10, 0x10})
        github.com/qdm12/ddns-updater/internal/settings/providers/inwx/provider.go:105 +0x27f
github.com/qdm12/ddns-updater/internal/update.(*Updater).Update(0xc000473740, {0xdd4848, 0xc00071e9b0}, 0xc10d1553dff45507?, {0xc000492120, 0x10, 0x10}, {0xc10d1553e10ebfd9, 0x1aa5cfc3, 0x130cec0})
        github.com/qdm12/ddns-updater/internal/update/update.go:47 +0x22e
github.com/qdm12/ddns-updater/internal/update.(*Runner).updateNecessary(0xc000474630, {0xdd4848, 0xc00071e9b0}, {0xc00071c0c0, 0x10, 0x10})
        github.com/qdm12/ddns-updater/internal/update/run.go:289 +0xa7d
github.com/qdm12/ddns-updater/internal/update.(*Runner).Run(0xc000474630, {0xdd4848, 0xc00071e9b0}, 0x0?)
        github.com/qdm12/ddns-updater/internal/update/run.go:307 +0x15d
created by main._main
        ./main.go:238 +0x160a

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qdm12/ddns-updater/pull/473 **Author:** [@stavros-k](https://github.com/stavros-k) **Created:** 5/4/2023 **Status:** ✅ Merged **Merged:** 5/9/2023 **Merged by:** [@qdm12](https://github.com/qdm12) **Base:** `master` ← **Head:** `patch-10` --- ### 📝 Commits (1) - [`ed76876`](https://github.com/qdm12/ddns-updater/commit/ed7687675c1905bdb81ef7d8d66f27cc49bc72d8) possible fix for panic ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/settings/providers/inwx/provider.go` (+1 -1) </details> ### 📄 Description I was getting a panic for inwx provider, from looking in the other providers looks like others was using this format instead of `var`. I have no Go Experiene, so this might be plain wrong. Here is the panic. ``` panic: assignment to entry in nil map goroutine 71 [running]: net/url.Values.Set(...) net/url/url.go:899 github.com/qdm12/ddns-updater/internal/settings/providers/inwx.(*Provider).Update(0xc0003181e0, {0xdd4848, 0xc00071e9b0}, 0x0?, {0xc000492120, 0x10, 0x10}) github.com/qdm12/ddns-updater/internal/settings/providers/inwx/provider.go:105 +0x27f github.com/qdm12/ddns-updater/internal/update.(*Updater).Update(0xc000473740, {0xdd4848, 0xc00071e9b0}, 0xc10d1553dff45507?, {0xc000492120, 0x10, 0x10}, {0xc10d1553e10ebfd9, 0x1aa5cfc3, 0x130cec0}) github.com/qdm12/ddns-updater/internal/update/update.go:47 +0x22e github.com/qdm12/ddns-updater/internal/update.(*Runner).updateNecessary(0xc000474630, {0xdd4848, 0xc00071e9b0}, {0xc00071c0c0, 0x10, 0x10}) github.com/qdm12/ddns-updater/internal/update/run.go:289 +0xa7d github.com/qdm12/ddns-updater/internal/update.(*Runner).Run(0xc000474630, {0xdd4848, 0xc00071e9b0}, 0x0?) github.com/qdm12/ddns-updater/internal/update/run.go:307 +0x15d created by main._main ./main.go:238 +0x160a ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

saavagebueno added the pull-request label 2025-11-20 04:25:48 -05:00

saavagebueno closed this issue

2025-11-20 04:25:48 -05:00

saavagebueno referenced this issue

2025-11-20 04:26:08 -05:00

[PR #710] [CLOSED] Debug log GCP credentials #809

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ddns-updater#710