[PR #775] [MERGED] Provider Porkbun: Remove trailing '.' from alias delete request #836

New Issue

saavagebueno · 2025-11-20T04:26:15-05:00

saavagebueno commented

2025-11-20 04:26:15 -05:00

📋 Pull Request Information

Original PR: https://github.com/qdm12/ddns-updater/pull/775
Author: @bentemple
Created: 7/27/2024
Status: ✅ Merged
Merged: 7/27/2024
Merged by: @qdm12

Base: master ← Head: ben.temple/fix-trailing-period

📝 Commits (1)

87815c0 Provider Porkbun: Remove trailing '.' from alias delete request

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 internal/provider/providers/porkbun/api.go (+1 -1)

📄 Description

Description

The porkbun documentation example request to delete a domain does not contain a trailing '.' URI Endpoint Example: https://api.porkbun.com/api/json/v3/dns/deleteByNameType/borseth.ink/A/www

This updates the code to match that.

Test-Plan

Changed delete to allow arbitrary deletes of any type (instead of just ALIAS)
Changed code to delete+create instead of update to change a porkbun domain Verified that delete works by deleting and creating a domain to update it instead of calling the update endpoint.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qdm12/ddns-updater/pull/775 **Author:** [@bentemple](https://github.com/bentemple) **Created:** 7/27/2024 **Status:** ✅ Merged **Merged:** 7/27/2024 **Merged by:** [@qdm12](https://github.com/qdm12) **Base:** `master` ← **Head:** `ben.temple/fix-trailing-period` --- ### 📝 Commits (1) - [`87815c0`](https://github.com/qdm12/ddns-updater/commit/87815c0235d6b4bae995b1de03ba1ffdc49dea96) Provider Porkbun: Remove trailing '.' from alias delete request ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/provider/providers/porkbun/api.go` (+1 -1) </details> ### 📄 Description # Description The porkbun documentation example request to delete a domain does not contain a trailing '.' `URI Endpoint Example: https://api.porkbun.com/api/json/v3/dns/deleteByNameType/borseth.ink/A/www` This updates the code to match that. # Test-Plan Changed delete to allow arbitrary deletes of any type (instead of just ALIAS) Changed code to delete+create instead of update to change a porkbun domain Verified that delete works by deleting and creating a domain to update it instead of calling the update endpoint. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

saavagebueno added the pull-request label 2025-11-20 04:26:15 -05:00

saavagebueno closed this issue

2025-11-20 04:26:15 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ddns-updater#836