[PR #773] [MERGED] Provider Porkbun: Fix wildcard domain modifications #837

New Issue

saavagebueno · 2025-11-20T04:26:15-05:00

saavagebueno commented

2025-11-20 04:26:15 -05:00

📋 Pull Request Information

Original PR: https://github.com/qdm12/ddns-updater/pull/773
Author: @bentemple
Created: 7/25/2024
Status: ✅ Merged
Merged: 8/7/2024
Merged by: @qdm12

Base: master ← Head: ben.temple/fix-porkbun-any-handling-1

📝 Commits (1)

e00b1c7 Provider Porkbun: Fix wildcard domain modifications

📊 Changes

1 file changed (+18 additions, -10 deletions)

View changed files

📝 internal/provider/providers/porkbun/api.go (+18 -10)

📄 Description

Description

Porkbun does not properly handle wildcard domains with an HTML encoded *. By default the URL is encoded, and * becomes %2A which then causes Porkbun to not return the correct DNS entry for *.domain.com resulting in duplicate *.domain.com DNS entries and other unwanted behavior. This updates the logic to append the domain owner (subdomain) to the url after HTML encoding it, preventing the '*' or any other subdomain characters from being HTML encoded.

Test-Plan

Setup several domains with *.domain.tld and domain.tld dns A entries.
Set the values for some dns A entries to 127.0.0.1
Verified that DDNS-Updater was able to correctly update all entries with the invalid IP address set.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qdm12/ddns-updater/pull/773 **Author:** [@bentemple](https://github.com/bentemple) **Created:** 7/25/2024 **Status:** ✅ Merged **Merged:** 8/7/2024 **Merged by:** [@qdm12](https://github.com/qdm12) **Base:** `master` ← **Head:** `ben.temple/fix-porkbun-any-handling-1` --- ### 📝 Commits (1) - [`e00b1c7`](https://github.com/qdm12/ddns-updater/commit/e00b1c7b4d7d6ce935ef472fe79481d9c8ccafd9) Provider Porkbun: Fix wildcard domain modifications ### 📊 Changes **1 file changed** (+18 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `internal/provider/providers/porkbun/api.go` (+18 -10) </details> ### 📄 Description # Description Porkbun does not properly handle wildcard domains with an HTML encoded `*`. By default the URL is encoded, and `*` becomes `%2A` which then causes Porkbun to _not_ return the correct DNS entry for `*.domain.com` resulting in duplicate `*.domain.com` DNS entries and other unwanted behavior. This updates the logic to append the domain owner (subdomain) to the url after HTML encoding it, preventing the '*' or any other subdomain characters from being HTML encoded. # Test-Plan Setup several domains with `*.domain.tld` and `domain.tld` dns `A` entries. Set the values for some dns `A` entries to `127.0.0.1` Verified that DDNS-Updater was able to correctly update all entries with the invalid IP address set. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

saavagebueno added the pull-request label 2025-11-20 04:26:15 -05:00

saavagebueno closed this issue

2025-11-20 04:26:15 -05:00

saavagebueno referenced this issue

2025-11-20 04:26:21 -05:00

[PR #837] [MERGED] Update porkbun api to new url #865

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ddns-updater#837