[PR #984] [MERGED] fix(ionos): use correct library for joining URL paths to avoid errors… #927

New Issue

saavagebueno · 2025-11-20T04:26:33-05:00

saavagebueno commented

2025-11-20 04:26:33 -05:00

📋 Pull Request Information

Original PR: https://github.com/qdm12/ddns-updater/pull/984
Author: @jccint
Created: 4/26/2025
Status: ✅ Merged
Merged: 11/1/2025
Merged by: @qdm12

Base: master ← Head: ionos-path-fix

📝 Commits (1)

586ab35 fix(ionos): use correct library for joining URL paths to avoid errors in Windows

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 internal/provider/providers/ionos/get.go (+2 -2)

📄 Description

… in Windows

Fixes issue #982

filepath.Join() is for filesystem paths, path.Join() should be used for URLs instead, as described here: https://github.com/golang/go/issues/30616

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qdm12/ddns-updater/pull/984 **Author:** [@jccint](https://github.com/jccint) **Created:** 4/26/2025 **Status:** ✅ Merged **Merged:** 11/1/2025 **Merged by:** [@qdm12](https://github.com/qdm12) **Base:** `master` ← **Head:** `ionos-path-fix` --- ### 📝 Commits (1) - [`586ab35`](https://github.com/qdm12/ddns-updater/commit/586ab35253b8876e306e4547dfa62860085f0b90) fix(ionos): use correct library for joining URL paths to avoid errors in Windows ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `internal/provider/providers/ionos/get.go` (+2 -2) </details> ### 📄 Description … in Windows Fixes issue #982 `filepath.Join()` is for filesystem paths, `path.Join()` should be used for URLs instead, as described here: https://github.com/golang/go/issues/30616 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

saavagebueno added the pull-request label 2025-11-20 04:26:33 -05:00

saavagebueno closed this issue

2025-11-20 04:26:34 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ddns-updater#927