starred/github-profile-views-counter
1
0
Fork 0
mirror of https://github.com/antonkomarev/github-profile-views-counter.git synced 2026-07-22 21:43:45 -04:00
Code Issues 24 Packages Projects Releases Wiki Activity

Use flock to avoid race conditions on views-count file (#67)

Browse Source
This commit is contained in:
Omar Adel Brikaa
2023-09-02 16:38:09 +03:00
committed by GitHub
parent 84ac753adf
commit bdaf96941f
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/CounterFileRepository.php
View File

@@ -57,8 +57,18 @@ final class CounterFileRepository implements
private function incrementViewsCount(Username $username): void
{
$counterFilePath = $this->getCounterFilePath($username);
// Need to open the file in "c" mode to avoid truncating before acquiring the lock and before reading
$counterFile = fopen($counterFilePath, "c");
file_put_contents($counterFilePath, $this->getViewsCountByUsername($username) + 1);
// Acquire an exclusive lock to avoid two requests causing a write at the same time
flock($counterFile, LOCK_EX);
$incremented = $this->getViewsCountByUsername($username) + 1;
ftruncate($counterFile, 0);
fwrite($counterFile, "$incremented\n");
fflush($counterFile);
// Release the exclusive lock
flock($counterFile, LOCK_UN);
fclose($counterFile);
}
private function getViewsFilePath(Username $username): string