mirror of
https://github.com/antonkomarev/github-profile-views-counter.git
synced 2026-07-13 17:21:51 -04:00
XSS in label parameter #20
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @arthurfiorette on GitHub (Apr 23, 2021).
Originally assigned to: @antonkomarev on GitHub.
I was creating my readme and i thought why not test if a script tag would work here? hahaha. It worked.
https://komarev.com/ghpvc/?username=arthurfiorette&style=flat-square&color=add8e6&label=%3Cscript%3Ealert(%27script%20with%20spaces!%27)%3C/script%3E
I haven't tested it much, but sometimes the server returns a 500 error, like when there is invalid html and so on. maybe it won't go anywhere, but it needs a check.
@antonkomarev commented on GitHub (Apr 23, 2021):
Thank you for the report @ArthurFiorette!
This image not meant to be called directly from komarev.com domain. GitHub proxies all images, JS scripts are not working. You could try to place it to your readme and click preview button to make sure. However, it would be good to fix this problem.
PRs are welcome.
@antonkomarev commented on GitHub (Jun 1, 2021):
Resolved with #31 by @JaderH