[PR #6] [MERGED] Add Username Value Object #79

Open
opened 2025-11-20 04:15:56 -05:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/antonkomarev/github-profile-views-counter/pull/6
Author: @antonkomarev
Created: 7/18/2020
Status: Merged
Merged: 7/18/2020
Merged by: @antonkomarev

Base: masterHead: add-username-value-object


📝 Commits (2)

📊 Changes

8 files changed (+129 additions, -17 deletions)

View changed files

📝 composer.json (+2 -1)
📝 composer.lock (+50 -1)
📝 contracts/CounterRepositoryInterface.php (+4 -2)
📝 public/database-repository.php (+3 -0)
📝 public/file-repository.php (+3 -0)
📝 src/CounterDatabaseRepository.php (+10 -6)
📝 src/CounterFileRepository.php (+13 -7)
src/Username.php (+44 -0)

📄 Description

All usernames are lowercase now. Counters with different cases in cloud application were merged.

eg. AntonKomarev -> antonkomarev


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/antonkomarev/github-profile-views-counter/pull/6 **Author:** [@antonkomarev](https://github.com/antonkomarev) **Created:** 7/18/2020 **Status:** ✅ Merged **Merged:** 7/18/2020 **Merged by:** [@antonkomarev](https://github.com/antonkomarev) **Base:** `master` ← **Head:** `add-username-value-object` --- ### 📝 Commits (2) - [`574e20a`](https://github.com/antonkomarev/github-profile-views-counter/commit/574e20ae37530ea08b4d2ad8cd8399e0af6fc1e8) Add Username VO - [`6692467`](https://github.com/antonkomarev/github-profile-views-counter/commit/6692467ab408a905e721a32928e82912bc2b8b04) Fix PDO repository ### 📊 Changes **8 files changed** (+129 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `composer.json` (+2 -1) 📝 `composer.lock` (+50 -1) 📝 `contracts/CounterRepositoryInterface.php` (+4 -2) 📝 `public/database-repository.php` (+3 -0) 📝 `public/file-repository.php` (+3 -0) 📝 `src/CounterDatabaseRepository.php` (+10 -6) 📝 `src/CounterFileRepository.php` (+13 -7) ➕ `src/Username.php` (+44 -0) </details> ### 📄 Description All usernames are lowercase now. Counters with different cases in cloud application were merged. eg. AntonKomarev -> antonkomarev --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:15:56 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/github-profile-views-counter#79