mirror of
https://github.com/BretFisher/jekyll-serve.git
synced 2026-07-28 00:32:36 -04:00
Do you really need to roll your own entrypoint script? #5
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @asarkar on GitHub (Nov 21, 2018).
docker-compose.yaml
Dockerfile
Is there anything more to it?
@BretFisher commented on GitHub (Nov 26, 2018):
Hi, I'm not sure what you're getting at. Your CMD example doesn't replicate what my entrypoint script does.
@asarkar commented on GitHub (Nov 26, 2018):
First of all, I might have come across as somewhat rude, sorry about that, that wasn't the intent.
I was looking for a way to start a Jekyll server quickly and came across your repo. From what I saw, you're not doing much in the entrypoint script, except for the
jekyll new, which seems to be somewhat contradictory with what you do next, i.e. look for an existing site.I don't wanna maintain a
Dockerfile, and eventually ended up with just a docker-compose.yml.@BretFisher commented on GitHub (Nov 27, 2018):
Yea that looks ruffly equivalent if you want to use the upstream image and you don't care about making new sites. You're really just trading out a Dockerfile for compose file complexity, but I like it!
My entrypoint script does two things:
I don't auto create new sites as that may not be what user intended.
@asarkar commented on GitHub (Nov 27, 2018):
I think our requirements are slightly different. I can’t get rid of the docker-compose, otherwise, I’ll have type all of it with
docker run, so, having one somewhat complex file makes more sense in my case than having two moderately simpler one.Thanks for your time.