starred/unifi-voucher-site
1
0
Fork 0
mirror of https://github.com/glenndehaan/unifi-voucher-site.git synced 2026-03-31 06:24:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

Ensure note field is always present within vouchers api call. Cleanup older comments. Simplify code. Implement separator check. Updated README.md

Browse Source
This commit is contained in:
Glenn de Haan
2025-12-30 09:39:55 +01:00
parent 122d2aebde
commit ea65b34a80
2 changed files with 17 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
README.md
View File

@@ -408,6 +408,7 @@ the different endpoints available in the API:
{
"id": "67bded6766f89f2a7ba6731f",
"code": "15695-53133",
"note": "Test",
"type": "multi",
"duration": 60,
"data_limit": "200",
@@ -417,6 +418,7 @@ the different endpoints available in the API:
{
"id": "67bdecd166f89f2a7ba67317",
"code": "03004-59449",
"note": null,
"type": "single",
"duration": 480,
"data_limit": null,
@@ -447,6 +449,15 @@ the different endpoints available in the API:
}
```
- Generate Voucher and Provide note:
```json
{
"type": "480,0,,,",
"note": "This is a note"
}
```
- Generate Voucher and Send Email *(**Warning**: Email module needs to be setup!)*:
```json

15
controllers/api.js
View File

@@ -111,12 +111,12 @@ module.exports = {
return {
id: voucher.id,
code: `${voucher.code.slice(0, 5)}-${voucher.code.slice(5)}`,
note: notes(voucher.name).note ? notes(voucher.name).note : null,
type: !voucher.authorizedGuestLimit ? 'multi' : voucher.authorizedGuestLimit === 1 ? 'single' : 'multi',
duration: voucher.timeLimitMinutes,
data_limit: voucher.dataUsageLimitMBytes ? voucher.dataUsageLimitMBytes : null,
download_limit: voucher.rxRateLimitKbps ? voucher.rxRateLimitKbps : null,
upload_limit: voucher.txRateLimitKbps ? voucher.txRateLimitKbps : null,
note: notes(voucher.name).note
upload_limit: voucher.txRateLimitKbps ? voucher.txRateLimitKbps : null
};
}),
updated: cache.updated
@@ -182,25 +182,22 @@ module.exports = {
return;
}
// Prepare optional note (sanitize to avoid breaking internal separator format)
// Prepare optional note
let noteInput = '';
if(typeof req.body.note !== 'undefined' && req.body.note !== null) {
if(typeof req.body.note !== 'string') {
if(typeof req.body.note !== 'string' && req.body.note === '' && req.body.note.includes('||;;||')) {
res.status(400).json({
error: 'Invalid Note!',
data: {}
});
return;
}
noteInput = req.body.note;
noteInput = req.body.note;
}
// Build the note string expected by utils/notes.js
const finalNote = `${noteInput}||;;||api||;;||local||;;||`;
// Create voucher code
const voucherCode = await unifi.create(types(req.body.type, true), 1, finalNote).catch((e) => {
const voucherCode = await unifi.create(types(req.body.type, true), 1, `${noteInput}||;;||api||;;||local||;;||`).catch((e) => {
res.status(500).json({
error: e,
data: {}