Compare commits

..

6 Commits

Author SHA1 Message Date
Diego Romar
691a90516d Change log.Debug in goroutine for log.Info 2025-12-19 12:47:52 -03:00
Diego Romar
76c63d0dd2 Track PopulateNetbirdConfig goroutine with e.shutdownWg 2025-12-19 12:46:49 -03:00
Diego Romar
ee9166d771 Remove outdated success log message 2025-12-18 16:37:43 -03:00
Diego Romar
5a91664116 Improve PopulateNetbirdConfig goroutine with retry logic 2025-12-18 16:27:37 -03:00
Diego Romar
0e9cddf2e8 Execute PopulateNetbirdConfig in a go routine 2025-12-18 13:58:31 -03:00
Diego Romar
72e1fe7b48 Add extra logs to engine and dns manager 2025-12-18 13:58:11 -03:00
4 changed files with 80 additions and 24 deletions

View File

@@ -56,7 +56,6 @@ block.prof: Block profiling information.
heap.prof: Heap profiling information (snapshot of memory allocations).
allocs.prof: Allocations profiling information.
threadcreate.prof: Thread creation profiling information.
stack_trace.txt: Complete stack traces of all goroutines at the time of bundle creation.
Anonymization Process
@@ -110,9 +109,6 @@ go tool pprof -http=:8088 heap.prof
This will open a web browser tab with the profiling information.
Stack Trace
The stack_trace.txt file contains a complete snapshot of all goroutine stack traces at the time the debug bundle was created.
Routes
The routes.txt file contains detailed routing table information in a tabular format:
@@ -331,10 +327,6 @@ func (g *BundleGenerator) createArchive() error {
log.Errorf("failed to add profiles to debug bundle: %v", err)
}
if err := g.addStackTrace(); err != nil {
log.Errorf("failed to add stack trace to debug bundle: %v", err)
}
if err := g.addSyncResponse(); err != nil {
return fmt.Errorf("add sync response: %w", err)
}
@@ -530,18 +522,6 @@ func (g *BundleGenerator) addProf() (err error) {
return nil
}
func (g *BundleGenerator) addStackTrace() error {
buf := make([]byte, 5242880) // 5 MB buffer
n := runtime.Stack(buf, true)
stackTrace := bytes.NewReader(buf[:n])
if err := g.addFileToZip(stackTrace, "stack_trace.txt"); err != nil {
return fmt.Errorf("add stack trace file to zip: %w", err)
}
return nil
}
func (g *BundleGenerator) addInterfaces() error {
interfaces, err := net.Interfaces()
if err != nil {

View File

@@ -96,10 +96,15 @@ func (m *Resolver) continueToNext(w dns.ResponseWriter, r *dns.Msg) {
func (m *Resolver) AddDomain(ctx context.Context, d domain.Domain) error {
dnsName := strings.ToLower(dns.Fqdn(d.PunycodeString()))
log.Infof("AddDomain: starting DNS lookup for %s", d.SafeString())
ctx, cancel := context.WithTimeout(ctx, dnsTimeout)
defer cancel()
ips, err := net.DefaultResolver.LookupNetIP(ctx, "ip", d.PunycodeString())
log.Infof("AddDomain: DNS lookup completed for %s, err=%v, ips=%d", d.SafeString(), err, len(ips))
if err != nil {
return fmt.Errorf("resolve domain %s: %w", d.SafeString(), err)
}

View File

@@ -420,10 +420,14 @@ func (e *Engine) Start(netbirdConfig *mgmProto.NetbirdConfig, mgmtURL *url.URL)
e.wgInterface = wgIface
e.statusRecorder.SetWgIface(wgIface)
log.Info("set wg interface to statusRecorder")
// start flow manager right after interface creation
publicKey := e.config.WgPrivateKey.PublicKey()
e.flowManager = netflow.NewManager(e.wgInterface, publicKey[:], e.statusRecorder)
log.Info("created flow manager")
if e.config.RosenpassEnabled {
log.Infof("rosenpass is enabled")
if e.config.RosenpassPermissive {
@@ -441,6 +445,8 @@ func (e *Engine) Start(netbirdConfig *mgmProto.NetbirdConfig, mgmtURL *url.URL)
}
e.stateManager.Start()
log.Info("started state manager")
initialRoutes, dnsConfig, dnsFeatureFlag, err := e.readInitialSettings()
if err != nil {
e.close()
@@ -454,10 +460,40 @@ func (e *Engine) Start(netbirdConfig *mgmProto.NetbirdConfig, mgmtURL *url.URL)
}
e.dnsServer = dnsServer
log.Info("created dns server")
// Populate DNS cache with NetbirdConfig and management URL for early resolution
if err := e.PopulateNetbirdConfig(netbirdConfig, mgmtURL); err != nil {
log.Warnf("failed to populate DNS cache: %v", err)
}
e.shutdownWg.Add(1)
go func() {
defer e.shutdownWg.Done()
backoff := time.Second
var lastErr error
const populateAttempts = 5
for attempts := 0; attempts < populateAttempts; attempts++ {
if pErr := e.PopulateNetbirdConfig(netbirdConfig, mgmtURL); pErr == nil {
log.Info("populated DNS cache successfully")
return
} else {
lastErr = pErr
log.Infof("populate DNS cache attempt %d failed: %v", attempts+1, pErr)
}
d := backoff + time.Duration(rand.Intn(500))*time.Millisecond
log.WithFields(log.Fields{"attempt": attempts + 1, "sleep": d}).Info("populate DNS cache retrying")
select {
case <-time.After(d):
case <-e.ctx.Done():
return
}
if backoff < 10*time.Second {
backoff *= 2
}
}
log.Errorf("failed to populate DNS cache after %d attempts: %v", populateAttempts, lastErr)
}()
e.routeManager = routemanager.NewManager(routemanager.ManagerConfig{
Context: e.ctx,
@@ -478,19 +514,27 @@ func (e *Engine) Start(netbirdConfig *mgmProto.NetbirdConfig, mgmtURL *url.URL)
log.Errorf("Failed to initialize route manager: %s", err)
}
log.Info("set route manager")
e.routeManager.SetRouteChangeListener(e.mobileDep.NetworkChangeListener)
log.Info("set route change listener to route manager")
if err = e.wgInterfaceCreate(); err != nil {
log.Errorf("failed creating tunnel interface %s: [%s]", e.config.WgIfaceName, err.Error())
e.close()
return fmt.Errorf("create wg interface: %w", err)
}
log.Info("created tunnel interface")
if err := e.createFirewall(); err != nil {
e.close()
return err
}
log.Info("created firewall")
e.udpMux, err = e.wgInterface.Up()
if err != nil {
log.Errorf("failed to pull up wgInterface [%s]: %s", e.wgInterface.Name(), err.Error())
@@ -498,6 +542,8 @@ func (e *Engine) Start(netbirdConfig *mgmProto.NetbirdConfig, mgmtURL *url.URL)
return fmt.Errorf("up wg interface: %w", err)
}
log.Info("pulled up tunnel interface")
// if inbound conns are blocked there is no need to create the ACL manager
if e.firewall != nil && !e.config.BlockInbound {
e.acl = acl.NewDefaultManager(e.firewall)
@@ -509,24 +555,38 @@ func (e *Engine) Start(netbirdConfig *mgmProto.NetbirdConfig, mgmtURL *url.URL)
return fmt.Errorf("initialize dns server: %w", err)
}
log.Info("initialized dns server")
iceCfg := e.createICEConfig()
log.Infof("created ICE config: %v", iceCfg)
e.connMgr = NewConnMgr(e.config, e.statusRecorder, e.peerStore, wgIface)
e.connMgr.Start(e.ctx)
log.Info("started connection manager")
e.srWatcher = guard.NewSRWatcher(e.signal, e.relayManager, e.mobileDep.IFaceDiscover, iceCfg)
e.srWatcher.Start()
log.Info("started SR watcher")
e.receiveSignalEvents()
e.receiveManagementEvents()
log.Info("started receiving events from Signal and Management services")
// starting network monitor at the very last to avoid disruptions
e.startNetworkMonitor()
log.Info("started network monitor")
// monitor WireGuard interface lifecycle and restart engine on changes
e.wgIfaceMonitor = NewWGIfaceMonitor()
e.shutdownWg.Add(1)
log.Infof("starting WireGuard interface monitor")
go func() {
defer e.shutdownWg.Done()
@@ -538,6 +598,8 @@ func (e *Engine) Start(netbirdConfig *mgmProto.NetbirdConfig, mgmtURL *url.URL)
}
}()
log.Info("engine started successfully")
return nil
}
@@ -731,21 +793,28 @@ func (e *Engine) PopulateNetbirdConfig(netbirdConfig *mgmProto.NetbirdConfig, mg
return nil
}
log.Info("PopulateNetbirdConfig: starting")
// Populate management URL if provided
if mgmtURL != nil {
log.Infof("PopulateNetbirdConfig: calling PopulateManagementDomain for %s", mgmtURL.Host)
if err := e.dnsServer.PopulateManagementDomain(mgmtURL); err != nil {
log.Warnf("failed to populate DNS cache with management URL: %v", err)
}
log.Info("PopulateNetbirdConfig: PopulateManagementDomain completed")
}
// Populate NetbirdConfig domains if provided
if netbirdConfig != nil {
log.Info("PopulateNetbirdConfig: calling UpdateServerConfig")
serverDomains := dnsconfig.ExtractFromNetbirdConfig(netbirdConfig)
if err := e.dnsServer.UpdateServerConfig(serverDomains); err != nil {
return fmt.Errorf("update DNS server config from NetbirdConfig: %w", err)
}
log.Info("PopulateNetbirdConfig: UpdateServerConfig completed")
}
log.Info("PopulateNetbirdConfig: done")
return nil
}

View File

@@ -20,7 +20,7 @@ type EndpointUpdater struct {
wgConfig WgConfig
initiator bool
// mu protects cancelFunc
// mu protects updateWireGuardPeer and cancelFunc
mu sync.Mutex
cancelFunc func()
updateWg sync.WaitGroup
@@ -86,9 +86,11 @@ func (e *EndpointUpdater) scheduleDelayedUpdate(ctx context.Context, addr *net.U
case <-ctx.Done():
return
case <-t.C:
e.mu.Lock()
if err := e.updateWireGuardPeer(addr, presharedKey); err != nil {
e.log.Errorf("failed to update WireGuard peer, address: %s, error: %v", addr, err)
}
e.mu.Unlock()
}
}