SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-05-12 11:12:15 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #554] [MERGED] New script: Mylar3 LXC #2592

New Issue
Closed
opened 2025-11-20 05:30:49 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:30:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/554
Author: @davalanche
Created: 11/27/2024
Status: ✅ Merged
Merged: 12/2/2024
Merged by: @MickLesk

Base: main ← Head: mylar3

📝 Commits (4)

  • d58a338 Add new LXC: Mylar3
  • 5c7da4f Apply suggestions from code review
  • 22ec9d3 Additional changes based on the code review
  • 03e8b1d The application is no longer updatable via the user interface

📊 Changes

3 files changed (+181 additions, -0 deletions)

View changed files

➕ ct/mylar3.sh (+79 -0)
➕ install/mylar3-install.sh (+68 -0)
➕ json/mylar3.json (+34 -0)

📄 Description

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

I have created a new LXC: Mylar3.

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

  • I chose to go with a git source install (clone) vs. a git release as the former allows for application updates through the user interface.
  • The unrar install logic was copied from the SABnzbd script.

Related Pull Requests / Discussions

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/554 **Author:** [@davalanche](https://github.com/davalanche) **Created:** 11/27/2024 **Status:** ✅ Merged **Merged:** 12/2/2024 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `mylar3` --- ### 📝 Commits (4) - [`d58a338`](https://github.com/community-scripts/ProxmoxVE/commit/d58a338765607689e9b118fb3a3547ecdda61512) Add new LXC: Mylar3 - [`5c7da4f`](https://github.com/community-scripts/ProxmoxVE/commit/5c7da4f2f9a1f990a413647fdb90670ae162c348) Apply suggestions from code review - [`22ec9d3`](https://github.com/community-scripts/ProxmoxVE/commit/22ec9d3c31b0c41f935b0d5ccfd19cf993b172f4) Additional changes based on the code review - [`03e8b1d`](https://github.com/community-scripts/ProxmoxVE/commit/03e8b1dbae9f739bbcd9897237d72d3868df3d16) The application is no longer updatable via the user interface ### 📊 Changes **3 files changed** (+181 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `ct/mylar3.sh` (+79 -0) ➕ `install/mylar3-install.sh` (+68 -0) ➕ `json/mylar3.json` (+34 -0) </details> ### 📄 Description > [!NOTE] > We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged. ## Description I have created a new LXC: Mylar3. ## Type of change Please check the relevant option(s): - [ ] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [X] New script (a fully functional and thoroughly tested script or set of scripts.) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [X] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [X] Testing performed (I have tested my changes, ensuring everything works as expected) - [X] Documentation updated (I have updated any relevant documentation) ## Additional Information (optional) - I chose to go with a git source install (clone) vs. a git release as the former allows for application updates through the user interface. - The unrar install logic was copied from the SABnzbd script. ## Related Pull Requests / Discussions - Related Discussion #312 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:30:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2592
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?