SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-13 01:22:09 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

Wireguard: Remove duplicated iptables POSTROUTING masquerade #554

New Issue
Closed
opened 2025-11-20 04:50:06 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:50:06 -05:00
Owner
Copy Link

Originally created by @Tunebox1 on GitHub (Feb 17, 2025).

Originally assigned to: @tremor021 on GitHub.

🌟 Briefly describe the feature

Masquerade should be only in POSTUP POSTDOWN and duplicated not in POSTROUTING

📝 Detailed description

  • remove iptables -t nat -A POSTROUTING -o eth0 -j MASQUERADE from script
  • masquerade is already in the wg0.conf postup and postdown, making it duplicated and harder to debug if you dont want to masquerade

💡 Why is this useful?

The Script is setting a masquerade aftert installing wireguard iptables -t nat -A POSTROUTING -o eth0 -j MASQUERADE while this is working as intended - for users that do not want to have MASQUERADE, this makes it harder to debug.

  1. This is duplicated, its in the postup postdown and also in the iptables
  2. Making it hard to debug / find the issue if you want to disable MASQUERADE:
    If you check the wg0.conf, you can find the MASQUERADE. If you check on the CLI with wg-quick up wg-quick down, you also can find it. So you delete it, thnking you wont doe masuqerade anymore but its still doing it. Only if you now check the iptables as an addition you can find it.

If you install Wireguard manually this is also not set so i think if you decide to set it by default (which i can understand since most users might want that), ONLY put it in the POSTUP and POSTDOWN.

Originally created by @Tunebox1 on GitHub (Feb 17, 2025). Originally assigned to: @tremor021 on GitHub. ### 🌟 Briefly describe the feature Masquerade should be only in POSTUP POSTDOWN and duplicated not in POSTROUTING ### 📝 Detailed description - remove `iptables -t nat -A POSTROUTING -o eth0 -j MASQUERADE` from script - masquerade is already in the wg0.conf postup and postdown, making it duplicated and harder to debug if you dont want to masquerade ### 💡 Why is this useful? The Script is setting a masquerade aftert installing wireguard `iptables -t nat -A POSTROUTING -o eth0 -j MASQUERADE` while this is working as intended - for users that do not want to have MASQUERADE, this makes it harder to debug. 1. This is duplicated, its in the postup postdown and also in the iptables 2. Making it hard to debug / find the issue if you want to disable MASQUERADE: If you check the wg0.conf, you can find the MASQUERADE. If you check on the CLI with `wg-quick up` `wg-quick down`, you also can find it. So you delete it, thnking you wont doe masuqerade anymore but its still doing it. Only if you now check the iptables as an addition you can find it. If you install Wireguard manually this is also not set so i think if you decide to set it by default (which i can understand since most users might want that), ONLY put it in the POSTUP and POSTDOWN.
saavagebueno added the enhancement label 2025-11-20 04:50:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#554
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?