saavagebueno/Proxmox
1
0
Fork 0
mirror of https://github.com/community-scripts/Proxmox.git synced 2026-03-31 06:34:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: Refactor fetchCategories function and improve code readability

Browse Source
This commit is contained in:
Bram Suurd
2024-08-03 14:47:05 +02:00
parent fcfe4f8f69
commit 893a7acbf6
1 changed files with 30 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
app/scripts/page.tsx
View File

@@ -1,24 +1,30 @@
"use client";
import ScriptItem from "@/components/ScriptItem";
import ScriptBrowser from "@/components/ScriptBrowser";
import { pb } from "@/lib/pocketbase";
import { Category } from "@/lib/types";
import { useEffect, useState, useCallback } from "react";
const getFullList = async (): Promise<Category[]> => {
const response = await pb.collection("categories").getFullList({
expand: "items",
sort: "order",
requestKey: "desktop",
const fetchCategories = async (): Promise<Category[]> => {
const response = await fetch("/api/categories", {
next: { revalidate: 60 * 60 * 24 },
});
return response as unknown as Category[];
if (!response.ok) {
throw new Error("Failed to fetch categories");
}
return response.json();
};
const sortCategories = (categories: Category[]): Category[] => {
return categories.sort((a: Category, b: Category) => {
if (a.catagoryName === "Proxmox VE Tools" && b.catagoryName !== "Proxmox VE Tools") {
if (
a.catagoryName === "Proxmox VE Tools" &&
b.catagoryName !== "Proxmox VE Tools"
) {
return -1;
} else if (a.catagoryName !== "Proxmox VE Tools" && b.catagoryName === "Proxmox VE Tools") {
} else if (
a.catagoryName !== "Proxmox VE Tools" &&
b.catagoryName === "Proxmox VE Tools"
) {
return 1;
} else {
return a.catagoryName.localeCompare(b.catagoryName);
@@ -26,10 +32,13 @@ const sortCategories = (categories: Category[]): Category[] => {
});
};
const fetchAndSortLinks = async (setLinks: (links: Category[]) => void, setIsLoading: (isLoading: boolean) => void) => {
const fetchAndSortLinks = async (
setLinks: (links: Category[]) => void,
setIsLoading: (isLoading: boolean) => void,
) => {
try {
setIsLoading(true);
const categories = await getFullList();
const categories = await fetchCategories();
if (categories.length === 0) {
throw new Error("Empty response");
}
@@ -63,10 +72,18 @@ export default function Page() {
<div className="mb-3 min-h-screen">
<div className="mt-20 flex sm:px-7 xl:px-0">
<div className="hidden sm:flex">
<ScriptBrowser items={links} selectedScript={selectedScript} setSelectedScript={setSelectedScript} />
<ScriptBrowser
items={links}
selectedScript={selectedScript}
setSelectedScript={setSelectedScript}
/>
</div>
<div className="mx-7 w-full sm:mx-0 sm:ml-7">
<ScriptItem items={links} selectedScript={selectedScript} setSelectedScript={setSelectedScript} />
<ScriptItem
items={links}
selectedScript={selectedScript}
setSelectedScript={setSelectedScript}
/>
</div>
</div>
</div>