Maintenance: fix linting errors

.golangci.yml

@@ -34,14 +34,6 @@ issues:
       linters:
         - maligned
         - dupl
-    - path: internal/settings/dreamhost\.go
-      text: "mnd: Magic number: 0x40, in <operation> detected"
-      linters:
-        - gomnd
-    - path: internal/settings/dreamhost\.go
-      text: "mnd: Magic number: 0x80, in <operation> detected"
-      linters:
-        - gomnd
 
 linters:
   disable-all: true

internal/params/json.go

@@ -83,6 +83,8 @@ func extractAllSettings(jsonBytes []byte) (allSettings []settings.Settings, warn
 	return allSettings, warnings, nil
 }
 
+// TODO remove gocyclo.
+//nolint:gocyclo
 func makeSettingsFromObject(common commonSettings, rawSettings json.RawMessage, matcher regex.Matcher) (
 	settingsSlice []settings.Settings, warnings []string, err error) {
 	provider := models.Provider(common.Provider)

internal/settings/dreamhost.go

@@ -142,7 +142,9 @@ type (
 func makeDreamhostDefaultValues(key string) (values url.Values) {
 	uuid := make([]byte, 16)
 	_, _ = io.ReadFull(rand.Reader, uuid)
+	//nolint:gomnd
 	uuid[6] = (uuid[6] & 0x0f) | 0x40 // Version 4
+	//nolint:gomnd
 	uuid[8] = (uuid[8] & 0x3f) | 0x80 // Variant is 10
 	values = url.Values{}
 	values.Set("key", key)

internal/settings/dynv6.go

@@ -13,7 +13,6 @@ import (
 	"github.com/qdm12/golibs/network"
 )
 
-//nolint:maligned
 type dynV6 struct {
 	domain        string
 	host          string

internal/settings/opendns.go

@@ -14,7 +14,6 @@ import (
 	"github.com/qdm12/golibs/network"
 )
 
-//nolint:maligned
 type opendns struct {
 	domain        string
 	host          string

internal/settings/ovh.go

@@ -14,7 +14,6 @@ import (
 	"github.com/qdm12/golibs/network"
 )
 
-//nolint:maligned
 type ovh struct {
 	domain        string
 	host          string